Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JPEG XL Support: Does not support container format. #5

Closed
Fraetor opened this issue Sep 30, 2021 · 2 comments
Closed

JPEG XL Support: Does not support container format. #5

Fraetor opened this issue Sep 30, 2021 · 2 comments
Labels
bug

Comments

@Fraetor
Copy link

Fraetor commented Sep 30, 2021

This viewer does not open JXL files that have a container, instead returning the error VipsForeignLoad: source is not a known format.

It does work for images with the container removed, or which where created without the container (which is the default for encoding jxl images from pixels.)

Here is a working example: (Remove .txt extension, its only there to allow GitHub upload)
no-container.jxl.txt
Here is a non-working example:
container.jxl.txt
@jcupitt
Copy link
Owner

jcupitt commented Oct 1, 2021

Oh hey, thanks @Fraetor. I'll have a look.

@jcupitt jcupitt added the bug label Oct 1, 2021
jcupitt added a commit to libvips/libvips that referenced this issue Oct 1, 2021
@jcupitt
allow container jxl as well
6a53ab4 
We were not testing the jxl signature for the two types of jxl.

see jcupitt/vipsdisp#5

thanks Fraetor
@jcupitt
Copy link
Owner

jcupitt commented Oct 1, 2021

OK, fixed in libvips master, thank you for pointing out this dumb thing.

@jcupitt jcupitt closed this as completed Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcupitt @Fraetor