imagewindow: Avoid use of GtkFileChooser* when GTK >= 4.10 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The GtkFileChooser APIs are deprecated in favor of the new GtkFileDialog API.
kleisauke
added a commit
to libvips/build-win64-mxe
that referenced
this pull request
Oct 31, 2023
|
I agree getting a native file chooser is nice, but the linux UI for file dialog that comes with 4.10 is VERY basic and I don't think anyone would want to use it. Maybe we should only use file dialog on Windows? |
|
o wai, perhaps I'm confused? I tried building this and it seems OK. Maybe it was just terrible in pre-4.10 gtk? |
|
Ah, you're right, it now also appears to open Nautilus instead of the basic one provided by GTK, at least on Fedora 38. |
|
I agree, let's use the new thing. |
|
(and thanks!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GtkFileChooser APIs are deprecated in favor of the new GtkFileDialog API.