Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad copper infills (kicad 7.0.0) #20

Closed
ThomHPL opened this issue May 14, 2023 · 3 comments
Closed

Bad copper infills (kicad 7.0.0) #20

ThomHPL opened this issue May 14, 2023 · 3 comments

Comments

@ThomHPL
Copy link
Contributor

ThomHPL commented May 14, 2023

When using a pcb file from kicad v7.0.0, some copper infills are not generated correctly due to some points being stored as "NaN" in the files generated by pcbmodelgen.

I tracked down the issue to a float issue in the function Zone::getVectAngle. I have made a quick fix and will issue a pull request soon.

Bad output

bad

Good output

good

Full kicad version info

Application: KiCad PCB Editor x64 on x64
Version: (7.0.0), release build
Libraries:
wxWidgets 3.2.1
FreeType 2.12.1
HarfBuzz 5.0.1
FontConfig 2.14.1
libcurl/7.83.1-DEV Schannel zlib/1.2.13
Platform: Windows 11 (build 22621), 64-bit edition, 64 bit, Little endian, wxMSW
Build Info:
Date: Feb 12 2023 01:35:19
wxWidgets: 3.2.1 (wchar_t,wx containers)
Boost: 1.80.0
OCC: 7.6.2
Curl: 7.83.1-DEV
ngspice: 39
Compiler: Visual C++ 1934 without C++ ABI
Build settings:
KICAD_SPICE=ON

ThomHPL added a commit to ThomHPL/pcbmodelgen that referenced this issue May 15, 2023
ThomHPL added a commit to ThomHPL/pcbmodelgen that referenced this issue May 18, 2023
ThomHPL added a commit to ThomHPL/pcbmodelgen that referenced this issue May 18, 2023
jcyrax added a commit that referenced this issue May 18, 2023
getVectAngle fix - issue #20
@leoheck
Copy link
Contributor

leoheck commented Jun 26, 2023

Hi guys, is this issue resolved?

@ThomHPL
Copy link
Contributor Author

ThomHPL commented Jun 30, 2023

Hi, my fix was merged and it works flawlessly for me. Let me know if you encounter issues.

@leoheck
Copy link
Contributor

leoheck commented Jul 1, 2023

Sure, this issue can be closed then. If I have issues I can open a new issue.

@ThomHPL ThomHPL closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants