Fix a bug in XAsyncSockets.py

[ekondayan]

The bug is in function IsSSL where the _socket object is tested to be an instance of SSLSocket. The correct is to test if the object is of class SSLContext.

#95

The SSLSocket attribute is not available in micropython for port esp32 and when initiating a simple GET crashes the server.

Unhandled exception in thread started by <bound_method>
Traceback (most recent call last):
File "MicroWebSrv2/libs/XAsyncSockets.py", line 131, in _processWaitEvents
File "MicroWebSrv2/libs/XAsyncSockets.py", line 587, in OnReadyForReading
File "MicroWebSrv2/libs/XAsyncSockets.py", line 830, in IsSSL
AttributeError: 'module' object has no attribute 'SSLSocket'

[DracoTomes]

This is still not entirely fixed, I ran into issues on my ESP32 because SSLSocket is still used a few lines below it.

MicroWebSrv2/MicroWebSrv2/libs/XAsyncSockets.py

Lines 835 to 838 in 7646c75

	@property
	def IsSSL(self) :
	return ( hasattr(ssl, 'SSLContext') and \
	isinstance(self._socket, ssl.SSLSocket) )

Replacing that will SSLContext as well (as actually checked in the function) works for me.

[jczic]

Ok @DracoTomes, that means that in MicroPython you have "SSLContext" as a socket attribute, otherwise the IF wouldn't go any further.
However, self._socket is in no way part of the SSLContext class. I will therefore also test "SSLSocket" as an attribute.

I know that the latest version of MicroPython implements SSL (TLS) with context and asynchronously, because this didn't exist before. But I haven't checked yet.

So I guess you don't use SSL in MicroPython at all?

[jczic]

b6f0799

The line "hasattr(ssl, 'SSLContext')" indicates that the system manages SSL "contexts".
I know this worked on MicroPython but there must have been a change in some versions.

[DracoTomes]

I'm running the newest 1.22.1 so it's probably something to do with the changes in newer version.
I have not used SSL yet (except for outgoing requests but I don't think that should matter).

[jczic]

@DracoTomes : But it should work now, shouldn't it?

[DracoTomes]

Oh yeah my bad. After implementing that change everything worked.

[jczic]

👍🏻