Fix crash with _GLIBCXX_ASSERTIONS #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfiguiere
commented
May 9, 2022
| std::copy(&_allFormants[val - 1][0], | ||
| &_allFormants[val - 1][NUM_FORMANTS_PER_VOWEL], | ||
| std::copy(_allFormants[val - 1].begin(), | ||
| _allFormants[val - 1].end(), |
There was a problem hiding this comment.
to be fair, I'm pretty sure the whole function can be rewrtiten as
Vowel SongbirdFilterModule<T>::getVowelDescription(int val) const {
return _allFormants[val - 1];
}
|
Thanks for spotting this, I wasn't planning on merging pull requests for this repo since I'm not totally sure about the implications for copyright, but I can look into making some changes here to tidy this up over the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Songbird crash when build with
-Wp,-D_GLIBCXX_ASSERTIONSon Linux.tl;dr you try to access an elment out of bounds.