Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep8 error #169

Merged
merged 4 commits into from
Feb 29, 2024
Merged

Fix pep8 error #169

merged 4 commits into from
Feb 29, 2024

Conversation

kajinamit
Copy link
Contributor

The following error is found by pep8.

./pifpaf/__main__.py:18:1: F401 'operator' imported but unused
import operator

The following error is found by pep8.

```
./pifpaf/__main__.py:18:1: F401 'operator' imported but unused
import operator
```
@kajinamit kajinamit closed this Feb 12, 2024
@kajinamit kajinamit reopened this Feb 12, 2024
tobias-urdin
tobias-urdin previously approved these changes Feb 12, 2024
It seems there is a problem with the repository maintained under
the pifpaf GitHub account. This is a short-term workaround and drops
dependency on the registry and makes the image always built during
CI run.
@mergify mergify bot dismissed tobias-urdin’s stale review February 12, 2024 08:49

Pull request has been modified.

@kajinamit
Copy link
Contributor Author

@jd I wonder if you mind checking the pifpaf github account and its github package settings, to ensure the target docker repository is enabled.

This fixes the AttributeError caused by recent version of packaging
library.
@tobias-urdin
Copy link
Collaborator

@felixonmars you merged these two broken pull requests that is reverted here
#166
#159

it would be better to focus on getting the CI green instead of merging untested code

... according to the recommendation in the python documentation.
@kajinamit
Copy link
Contributor Author

I wonder if this can be merged to unblock CI ?

@tobias-urdin tobias-urdin merged commit 55954f9 into jd:master Feb 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants