Fix wrong import #149
Merged
Fix wrong import #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, what's wrong with CI? Couldn't find the caller of failing |
|
Yea the npm ci call is coming from within Travis I think :( not sure what's going on there. I've been experimenting with downgrading libraries. I've also through of trying circle ci or even gitlab ci to see if it persists |
|
Okay, let me play around a bit with the config |
pablobirukov
force-pushed
the
fix-wrong-import
branch
from
42808e9
to
8d9724e
Compare
pablobirukov
force-pushed
the
fix-wrong-import
branch
from
8d9724e
to
2dc3657
Compare
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mdsb100
pushed a commit
to mdsb100/node-gitlab
that referenced
this pull request
Aug 17, 2018
* Fix incorrectly imported 'wait' * Updated README to mention that we assume Promise polyfilled
mdsb100
pushed a commit
to mdsb100/node-gitlab
that referenced
this pull request
Aug 17, 2018
* Fix incorrectly imported 'wait' * Updated README to mention that we assume Promise polyfilled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to #137, I tried to check ts build and compiler reported another runtime error