Skip to content

Commit 62e032b

Browse files
committed
refactor: Triggers API required arguments exposed as optional
The Trigger API's pipeline function requires two new arguments, the ref and token but was previously exposed as optional arguments. BREAKING CHANGE: Triggers API pipeline function requires the ref and token
1 parent 7453779 commit 62e032b

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

src/services/Triggers.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,37 +1,40 @@
11
import { BaseService, RequestHelper } from '../infrastructure';
2-
import { RequestOptions } from '../infrastructure/RequestHelper';
3-
4-
type TriggerId = string | number;
52

63
class Triggers extends BaseService {
7-
add(projectId: ProjectId, options: RequestOptions) {
4+
add(projectId: ProjectId, options?: BaseRequestOptions) {
85
const pId = encodeURIComponent(projectId);
96

107
return RequestHelper.post(this, `projects/${pId}/triggers`, options);
118
}
129

13-
all(projectId: ProjectId) {
10+
all(projectId: ProjectId, options?: PaginatedRequestOptions) {
1411
const pId = encodeURIComponent(projectId);
1512

16-
return RequestHelper.get(this, `projects/${pId}/triggers`);
13+
return RequestHelper.get(this, `projects/${pId}/triggers`, options);
1714
}
1815

19-
edit(projectId: ProjectId, triggerId: TriggerId, options: RequestOptions) {
16+
edit(projectId: ProjectId, triggerId: TriggerId, options?: BaseRequestOptions) {
2017
const [pId, tId] = [projectId, triggerId].map(encodeURIComponent);
2118

2219
return RequestHelper.put(this, `projects/${pId}/triggers/${tId}`, options);
2320
}
2421

25-
remove(projectId: ProjectId, triggerId: TriggerId) {
22+
remove(projectId: ProjectId, triggerId: TriggerId, options?: Sudo) {
2623
const [pId, tId] = [projectId, triggerId].map(encodeURIComponent);
2724

28-
return RequestHelper.delete(this, `projects/${pId}/triggers/${tId}`);
25+
return RequestHelper.del(this, `projects/${pId}/triggers/${tId}`, options);
2926
}
3027

31-
show(projectId: ProjectId, triggerId: TriggerId) {
28+
show(projectId: ProjectId, triggerId: TriggerId, options?: Sudo) {
3229
const [pId, tId] = [projectId, triggerId].map(encodeURIComponent);
3330

34-
return RequestHelper.get(this, `projects/${pId}/triggers/${tId}`);
31+
return RequestHelper.get(this, `projects/${pId}/triggers/${tId}`, options);
32+
}
33+
34+
pipeline(projectId: ProjectId, ref: string, token: string, options?: Sudo) {
35+
const pId = encodeURIComponent(projectId);
36+
37+
return RequestHelper.post(this, `projects/${pId}/trigger/pipeline`, { ref, token, ...options });
3538
}
3639
}
3740

0 commit comments

Comments
 (0)