Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressed button text position #45

Closed
DiskJunky opened this issue Apr 23, 2020 · 4 comments
Closed

Pressed button text position #45

DiskJunky opened this issue Apr 23, 2020 · 4 comments

Comments

@DiskJunky
Copy link

DiskJunky commented Apr 23, 2020

On a Windows machine (98 style), the button text actually shifts down and right a pixel, contributing to the 'pressed' look and feel.

I have a fix for this but don't have contributor access to submit a PR for review. It was...surprisingly finicky to get right cross-browser.

@jdan
Copy link
Owner

jdan commented Apr 23, 2020

Dupe #34 :)

@jdan jdan closed this as completed Apr 23, 2020
@jdan
Copy link
Owner

jdan commented Apr 23, 2020

@DiskJunky just a heads up that you don't need contributor access to submit a PR :) You fork the repo to your own account, then push commits there before submitting a branch in your repo as a pull request to this one.

https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-requests

@DiskJunky
Copy link
Author

Ahh, that was annoying me, thank you! I genuinely wasn't sure what the process was 👍

@jdan
Copy link
Owner

jdan commented Apr 23, 2020

@DiskJunky Definitely feel free to drop a note here (or to my email) if I can be of any help, it's a confusing flow but I'd love your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants