Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button text should move when button is pressed #34

Closed
tpenguinltg opened this issue Apr 22, 2020 · 4 comments
Closed

Button text should move when button is pressed #34

tpenguinltg opened this issue Apr 22, 2020 · 4 comments

Comments

@tpenguinltg
Copy link

I don't have a copy of Windows 98 handy to check and capture a video of this in action (or any versions of Windows, for that matter), but the behaviour of Windows Classic on newer versions of Windows is that the text of a button moves when the button is in a depressed state. I don't expect this to have been different in Windows 98.

According to my theme designer, the text moves 1px down and 1px right from its normal position.

@jdan
Copy link
Owner

jdan commented Apr 22, 2020

Phenomenal catch :)

@padraigfl
Copy link

Can verify this one, button content overall (e.g. icons in the tabs on the taskbar)

@DiskJunky
Copy link

I don't have a copy of Windows 98 handy to check and capture a video of this in action (or any versions of Windows, for that matter), but the behaviour of Windows Classic on newer versions of Windows is that the text of a button moves when the button is in a depressed state. I don't expect this to have been different in Windows 98.

According to my theme designer, the text moves 1px down and 1px right from its normal position.

Correct. Spent a lot of time writing Windows controls back in the day, including buttons. 1px offset down and right on a click.

@jdan
Copy link
Owner

jdan commented Jun 19, 2020

Fixed via #44

@jdan jdan closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants