Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user agent summary arrow #132

Merged
merged 2 commits into from
May 22, 2022

Conversation

isiah-lloyd
Copy link
Collaborator

@isiah-lloyd isiah-lloyd commented May 19, 2022

Browsers by default show an arrow next to <summary> elements, this is redundant for 98.css as it has it's own marker. Without disabling this marker two separate markers will be shown:

image

docs.css fixed this for the docs website but this is something that should be pulled up to the main stylesheet.

The rule uses the new ::marker pseduo-element which is supported by all modern browsers except for Safari which is why the vendor prefixed ::-webkit-details-marker is also included.

(Beta versions of Safari add support for ::marker so the vendor prefixed selector could be dropped in the near future)

- Remove docs.css specific rule that fixed this
@vercel
Copy link

vercel bot commented May 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
98css ✅ Ready (Inspect) Visit Preview May 20, 2022 at 0:37AM (UTC)

@isiah-lloyd
Copy link
Collaborator Author

Turns out setting display: none doesn't actually fix anything. The docs stylesheet had another rule for summary that set it to inline (which for some reason also gets rid of the marker). Setting the content to an empty string seems to actually remove the marker.

@isiah-lloyd isiah-lloyd merged commit ec33cdb into jdan:main May 22, 2022
@isiah-lloyd isiah-lloyd deleted the fix/details-marker branch May 22, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant