Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CLI based on Feedback #13

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

jordlay
Copy link
Collaborator

@jordlay jordlay commented May 25, 2023

PR includes:

  • adding meaningful logs
  • error handling for not providing parameters in ARM template
  • preventing auto overwriting of input.json
  • adding clarifying comments to help text
  • convert vnf types in schema

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@jddarby
Copy link
Owner

jddarby commented May 26, 2023

Are we satisfying the azdev style command after this PR?

@jordlay jordlay merged commit 276d3ca into add-aosm-extension May 26, 2023
@jordlay jordlay deleted the jl/first-round-feedback branch June 1, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants