Replace /hub with /.well-known/mercure #15
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You mentioned in #14 that Mercure has recently changed the hub URL from /hub to /.well-known/mercure (dunglas/mercure#182).
I've made the changes in the source and docs and run the Docker and Kubernetes examples. Both work fine now. I've succesfully run the test suite. This is my first golang commit so forgive me if I forget anything obvious.
I get the linting warnings below but they're all marked with wsl (I use Win10 WSL for development) and already existed on your master/HEAD so I haven't attempted to resolve them:
I'm also not sure if I should commit the go.sum and go.mod files. go.mod has a dozen changes but they're all marked
// indirect
. Any advice on that?