Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace /hub with /.well-known/mercure #15

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Replace /hub with /.well-known/mercure #15

merged 1 commit into from
Nov 21, 2019

Conversation

Yggdrasil
Copy link
Contributor

You mentioned in #14 that Mercure has recently changed the hub URL from /hub to /.well-known/mercure (dunglas/mercure#182).

I've made the changes in the source and docs and run the Docker and Kubernetes examples. Both work fine now. I've succesfully run the test suite. This is my first golang commit so forgive me if I forget anything obvious.

I get the linting warnings below but they're all marked with wsl (I use Win10 WSL for development) and already existed on your master/HEAD so I haven't attempted to resolve them:

pkg/broadcaster/broadcaster.go:34:5: expressions should not be cuddled with blocks (wsl)
                                b.Stop()
                                ^
pkg/broadcaster/broadcaster.go:36:4: expressions should not be cuddled with blocks (wsl)
                        b.wg.Done()
                        ^
pkg/broadcaster/broadcaster.go:48:5: expressions should not be cuddled with blocks (wsl)
                                b.Stop()
                                ^
pkg/broadcaster/broadcaster.go:87:3: for statement without condition should never be cuddled (wsl)
                for {
                ^

I'm also not sure if I should commit the go.sum and go.mod files. go.mod has a dozen changes but they're all marked // indirect. Any advice on that?

@jderusse
Copy link
Owner

Thank you for your contribution. I've created #16 to Fix CS and update go.mod and go.sum files. And #13 to Fix tests.

Could you please rebase your PR?

@jderusse jderusse merged commit 273383e into jderusse:master Nov 21, 2019
@Yggdrasil
Copy link
Contributor Author

Thanks for the swift update. Done!

@jderusse
Copy link
Owner

Thank you @Yggdrasil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants