update some mappings #271
Merged
update some mappings #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix a typo in gJ mapping when setting the mark, the correct syntax is `mz` (set mark `z`), not `zm` 2. fix bug with `iB` text object: previously `viB` does not work as expected, because it does not select the entire buffer as expected. After much investigation, I found it is because the `<cmd>` mapping argument. If we use `<cmd>` argument for mapping, the mode does not change. So if we use `viB`, inititally we are still in visual mode. Later in the implementation, when we use `` normal! `<V`> `` to select the entire buffer, it interferes with original visual mode. As a result, the entire buffer is not selected. In the text obj implementation, we can use `exe "normal! \<Esc>"` to clear the visual mode and make `viB`, but this is not ideal. I think it is eaiser to just not use the `<cmd>` argument and use `:<C-U>` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a typo in gJ mapping when setting the mark, the correct syntax is
mz(set markz), notzmfix bug with
iBtext object: previouslyviBdoes not work as expected, because it does not select the entire buffer as expected. After much investigation, I found it is because the<cmd>mapping argument. If we use<cmd>argument for mapping, the mode does not change. So if we useviB, inititally we are still in visual mode. Later in the implementation, when we usenormal! `<V`>to select the entire buffer, it interferes with original visual mode. As a result, the entire buffer is not selected. In the text obj implementation, we can useexe "normal! \<Esc>"to clear the visual mode and makeviB, but this is not ideal. I think it is eaiser to just not use the<cmd>argument and use:<C-U>instead.