Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a Docker container to run in the background? #18

Closed
adyotag opened this issue Oct 15, 2022 · 4 comments · Fixed by #19
Closed

Adding a Docker container to run in the background? #18

adyotag opened this issue Oct 15, 2022 · 4 comments · Fixed by #19
Labels
enhancement New feature or request

Comments

@adyotag
Copy link

adyotag commented Oct 15, 2022

This could be a nice feature to add in the future... It also avoids issues with dependencies across different systems as everything is standardized under the container.

@adyotag adyotag changed the title Adding a Docker container to run in the background? Adding a Docker container to run in the background? label:enhancement\ Oct 15, 2022
@adyotag adyotag changed the title Adding a Docker container to run in the background? label:enhancement\ Adding a Docker container to run in the background? label:enhancement Oct 15, 2022
@adyotag adyotag changed the title Adding a Docker container to run in the background? label:enhancement Adding a Docker container to run in the background? Oct 15, 2022
@jdholtz jdholtz added the enhancement New feature or request label Oct 15, 2022
@jdholtz
Copy link
Owner

jdholtz commented Oct 15, 2022

Thanks for the request! I plan to implement this by the end of the year, but hopefully sooner if I have time. Feel free to help contribute towards this if you want.

@schmeed schmeed mentioned this issue Oct 18, 2022
@sdstolworthy
Copy link
Contributor

I'll see if I can't take a whack at that next week. I'll have a couple hours of free time.

@adyotag
Copy link
Author

adyotag commented Oct 22, 2022

I'll see if I can't take a whack at that next week. I'll have a couple hours of free time.

I'd love to help out as well!

@sdstolworthy
Copy link
Contributor

@adyotag and @jdholtz just put up a PR for your review

jdholtz added a commit that referenced this issue Oct 26, 2022
Adds support for running the script in Docker. Fixes #18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants