Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1284: get css locators from backend #1732

Merged
merged 15 commits into from
May 13, 2024
Merged

Issue 1284: get css locators from backend #1732

merged 15 commits into from
May 13, 2024

Conversation

Iogsotot
Copy link
Contributor

@Iogsotot Iogsotot commented May 13, 2024 •
edited
Loading

Features

  • Updated CSS selector generation to activate when 'CSS selector' is selected in Page Object config.
  • Enhanced throttling mechanisms for improved performance.
  • Implemented functionality to retrieve CSS from the backend via WebSocket.
  • Added functionality to generate unique CSS selectors.
  • Updated properties for Locator Icon to enhance interface interactions.
  • Optimized HTML by removing script tags and minimizing content before sending to the backend.

Refactors

  • General code cleanup including removing redundant code, fixing naming conventions, and increasing readability.
  • Updated webSocketMessageHandler.ts with additional types for enhanced code safety.
  • Rewrote addPageObject.thunk.js in TypeScript to improve maintainability and type safety.
  • Minor adjustments including typo corrections and type fixes across various modules.
  • Remove taskStatus filed from locator.locatorValue

Fixes

  • Fixed issue where CSS selector generation did not trigger appropriately.
  • Removed double stringification of backend messages and corrected associated types.

@Iogsotot
feat: remove Script Tags and minify HTML before sending to backend (s…
5308aaa 
…endToModel)
@Iogsotot
refactor: typo
0150846
@Iogsotot
feat: update props for Locator Icon
e4731f2
@Iogsotot
refactor: code cleanup, fix naming, increase readability, del redunda…
708c60d 
…nt code, fix types
@Iogsotot
feat: add function to generate an original(unique) css selector
dfca94e
@Iogsotot
refactor: rewrite addPageObject.thunk.js to TS
0eb97bd
@Iogsotot
feat: get CSS from backend (WS)
23da808
@Iogsotot
refactor: fix types
6fb6862
@Iogsotot
fix: remove double stringify for backend messages, fix types
ab1c9ea
@Iogsotot
refactor: update naming, fix typos, fix types
3cc1c44
@Iogsotot
feat: update throttler
98903b2
@Iogsotot
refactor: add types, update webSocketMessageHandler.ts
4dc95d5
@Iogsotot
fix: run CSS selector generation when selected Locators type: CSS sel…
bfa55d4 
…ector in Page Object config
@Iogsotot
refactor: del redundant code, code cleanup
15daf48
@Iogsotot Iogsotot self-assigned this May 13, 2024
@Iogsotot Iogsotot force-pushed the issue_1284-get-css-locators-from-backend branch from 5a5211a to 10702f5 Compare May 13, 2024 10:02
@Iogsotot Iogsotot merged commit eed609a into master May 13, 2024
2 of 3 checks passed
@Iogsotot Iogsotot deleted the issue_1284-get-css-locators-from-backend branch May 13, 2024 10:06
@Iogsotot Iogsotot mentioned this pull request May 13, 2024
Closed
@Iogsotot Iogsotot linked an issue May 13, 2024 that may be closed by this pull request
[US-15-1] Фоновый расчёт CSS селекторов - UI part #1284
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Iogsotot Iogsotot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[US-15-1] Фоновый расчёт CSS селекторов - UI part
1 participant
@Iogsotot