Address issue with self.node artifacts ... #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is currently required for Travis to make Python 3.5 available in the build environment. This makes the py35 Tox env work, and should not affect the others.
4a8b003 test_main.py, test_utils.py: Use assert_called_once_with(), not assert_called_once() assert_called_once() is not actually a valid assertion method: the mock object treats it as a mocked method, which silently returns without doing anything. The right assertion method to use is assert_called_once_with(). (This makes several tests fail that were falsely passing before.) For more about this problem, see: http://engineeringblog.yelp.com/2015/02/assert_called_once-threat-or-menace.html cd18a5d test_main.py: Tell CliRunner.invoke() to not catch exceptions This makes it much easier to investigate test failures. 254486b test_main.py: Expand and make test_main.test_update pass c08bef8 test_utils.py Update and make test_utils.test_update_mime_types pass This is hopefully faithful to the original intent of this test.
3453b81 test_parser.py: Fix hash order dependency in test_resource_assigned_type This makes the test pass deterministically. 9c57a40 test_parser.py: Fix hash order dependency in test_resource_inherits_get These two resources were previously listed in an unpredictable order, relative to each other: this way, the test does not depend on a particular order. fc1269d .travis.yml, tox.ini: Remove hash seed hard-coding from Tox and Travis configs The tests should now pass without this. 4047bf7 AUTHORS.rst: Add myself to the contributor list
…projects As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’: > Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard. Test Plan: Manually visited all the links I’ve modified.
Codecov Report
@@ Coverage Diff @@
## v0.2.0-dev #141 +/- ##
==============================================
- Coverage 95.74% 95.61% -0.13%
==============================================
Files 40 40
Lines 1950 1940 -10
==============================================
- Hits 1867 1855 -12
- Misses 83 85 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And apparently merge a bunch of things I forgot to commit :-!