Feature/data provider api #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matcher - this was producing deprecation warnings
DataProvider API strategy
as a Concern-style module, and introducing the data_provider_for model DSL. We can now include the Concern and use data_provider_for :x, :y, :z in our API provider classes. This will automatically execute matching methods to those symbols on create, otherwise raising a NotImplemented exception. This is the underpinning for making API additions fast, and consistent. In the future, we should only have to define the internals of each symboled type of resource provided to data_provider_for
config to get rid of deprecation error
unit - in case we don't know the initial unit
…dded a few matchers to sleep spec
the specs can run for each individual API provider
have to handle this later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.