Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"About" header link does nothing in Firefox 53.0.2 #68

Closed
Nightfirecat opened this issue May 12, 2017 · 5 comments
Closed

"About" header link does nothing in Firefox 53.0.2 #68

Nightfirecat opened this issue May 12, 2017 · 5 comments
Assignees
@Nightfirecat
Labels
bug

Comments

@Nightfirecat
Copy link
Member

No description provided.

@tupaschoal
Copy link
Member

Really? For me it scrolls to the bottom of the page. What are you seeing?

@Nightfirecat Nightfirecat changed the title "About" header link does nothing "About" header link does nothing in Firefox 53.0.2 May 13, 2017
@Nightfirecat
Copy link
Member Author

Updated title since it seems to work fine in Chrome, but not Firefox.

@tupaschoal tupaschoal added bug and removed question labels May 13, 2017
@tupaschoal
Copy link
Member

Weird, it does work on Chrome and Edge, but not Firefox.

@Nightfirecat
Copy link
Member Author

I'll take a look at this after my search bar updates since that sounds like it ought to be an easy fix, whatever it is.

That said, I've said the same about cross-browser weirdness before while diving into endless rabbit-holes of confused developers, so I'll just make sure to comment back here later once I take a crack at it.

@Nightfirecat
Copy link
Member Author

Nightfirecat commented May 13, 2017 •
edited
Loading

Didn't manage to dig much up tonight... Will do some more thorough debugging in FF/Chrome tomorrow to see if I can pinpoint the difference.

EDIT: I spoke too soon... http://stackoverflow.com/a/8149216/540162

Nightfirecat added a commit to Nightfirecat/jdm that referenced this issue May 13, 2017
@Nightfirecat
Fix FireFox scrollTo bug
031668d 
In Firefox, the document overflow is placed at the `<html>` level, so
the tag must be included in `scrollTo()` invocations.

Ref: http://stackoverflow.com/a/8149216/540162

Fixes jdm-contrib#68
@Nightfirecat Nightfirecat mentioned this issue May 13, 2017
Merged
tupaschoal pushed a commit that referenced this issue May 13, 2017
@Nightfirecat @tupaschoal
Fix FireFox scrollTo bug (#75)
fe977ae 
In Firefox, the document overflow is placed at the `<html>` level, so
the tag must be included in `scrollTo()` invocations.

Ref: http://stackoverflow.com/a/8149216/540162

Fixes #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nightfirecat Nightfirecat

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nightfirecat @tupaschoal