feat(mrml-python): add a Python types stub file #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blopker
commented
Apr 19, 2024
| @@ -214,7 +214,7 @@ fn to_html( | |||
|
|
|||
| #[pymodule] | |||
| #[pyo3(name = "mrml")] | |||
| fn register(_py: Python<'_>, m: &PyModule) -> PyResult<()> { | |||
| fn register(_py: Python<'_>, m: &Bound<'_, PyModule>) -> PyResult<()> { | |||
There was a problem hiding this comment.
The one breaking change in this file that affected PyO3 0.21
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
jdrouet
force-pushed
the
feature/python-types
branch
from
94cd5f8
to
f2d85eb
Compare
|
👍 Thanks for this, that's amazing! |
jdrouet
changed the title
|
Great! Thanks for the merge. I think the doc strings leave some room for improvement, but good enough for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #412
All the test files now lint correctly with Pylance in VSCode. 🎉