Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a couple of issues in
find_rotation_seed_coord()
that had repercussions oncalc_shape_dist()
. The latter now performs the same calculations as incurve_pair_align()
. In particular, the objectbeta2best
output byfind_rotation_seed_coord()
is properly rotated and scaled whenrotation == TRUE
andscale == TRUE
which makes it directly useable incalc_shape_dist()
andcurve_pair_align()
without the need to perform the rotation, scaling and group action again a posteriori.calc_shape_dist()
is also better documented and its output has been augmented.d
anddx
for amplitude and phase distances could have better names.betascale
which is intended to be the optimal scaling factor that has been applied to the second curve whenscale == TRUE
; it is nothing but the length ofbeta1
divided by the length ofbeta2
;qscale
as well but it is not currently the case.Lastly, I feel that we should document that the output
beta1
is slightly different from the input of the same name. by clarifying what the centring performed viacalculatecentroid()
does.