Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish_command_not_found override breaks default command-not-found implementation #1619

Closed
kevindetry opened this issue Feb 6, 2024 · 2 comments · Fixed by #1624
Closed

fish_command_not_found override breaks default command-not-found implementation #1619

kevindetry opened this issue Feb 6, 2024 · 2 comments · Fixed by #1624
Labels
bug Something isn't working

Comments

@kevindetry
Copy link

Describe the bug
mise activate fish overrides the default fish_command_not_found implementation in a way that breaks the default command-not-found handling.

To Reproduce
Using Arch, add mise activate fish | source to ~/.config/fish/config.fish. Try to call a binary that isn't installed:

~> htop
fish: Unknown command: htop

Expected behavior
Using Arch with pkgfile installed, without mise activate fish | source in config:

~> htop
htop may be found in the following packages:
  extra/htop 3.3.0-1	/usr/bin/htop

mise doctor output

mise version:
  2024.2.4 linux-x64 (2024-02-05)

build:
  Target: x86_64-unknown-linux-gnu
  Features: DEFAULT, NATIVE_TLS
  Built: Mon, 5 Feb 2024 22:00:01 +0000
  Rust Version: rustc 1.75.0 (82e1608df 2023-12-21)
  Profile: release

shell:
  fish
  fish, version 3.7.0

mise data directory:
  /home/kevindetry/.local/share/mise

mise environment variables:
  MISE_SHELL=fish

settings:
  activate_aggressive = false
  all_compile = false
  always_keep_download = false
  always_keep_install = false
  asdf_compat = false
  cargo_binstall = true
  color = true
  disable_default_shorthands = false
  disable_tools = []
  experimental = false
  jobs = 4
  legacy_version_file = true
  legacy_version_file_disable_tools = []
  node_compile = false
  not_found_auto_install = true
  paranoid = false
  plugin_autoupdate_last_check_duration = "7d"
  python_compile = false
  python_default_packages_file = "/home/kevindetry/.default-python-packages"
  python_pyenv_repo = "https://github.com/pyenv/pyenv.git"
  python_venv_auto_create = false
  raw = false
  trusted_config_paths = []
  quiet = false
  verbose = false
  yes = false
  ci = false
  debug = false
  trace = false
  log_level = "info"

  [status]
  missing_tools = "if_other_versions_installed"
  show_env = false
  show_tools = false


config files:

plugins:
  bun      (core)
  deno     (core)
  go       (core)
  java     (core)
  node     (core)
  python   (core)
  ruby     (core)

toolset:


No problems found
@kevindetry
Copy link
Author

Seems to be broken again with #1665

Without and not functions -q __mise_fish_command_not_found command-not-found handler works as expected.

@kevindetry
Copy link
Author

@jdx, would it be possible to reopen this issue? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant