env: resolve env vars in order #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdx
force-pushed
the
env-man
branch
3 times, most recently
from
7fc3b23
to
871abf9
Compare
|
@Ajpantuso wanted to draw your attention to this PR just so you're aware of it since I know you worked on some of the env stuff a bit. I'd hold off on any env-related things for a couple of days until I can get this out since all of that logic is going to change. |
jdx
force-pushed
the
env-man
branch
12 times, most recently
from
3165305
to
44cab31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a major refactor of how env vars are handled. Previously, they were resolved as part of parsing but they really need to be done one at a time so that the results of each var can be used for the next one. This should also make it possible to greatly simplify how env vars are handled in tools by using the same logic.
Fixes #1262
Prereq for #1447
Prereq for #1303
Prereq for #1261