feat(doctor): identify missing/extra shims #1524

Ajpantuso · 2024-01-25T15:55:40Z

Summary

These changes enable mise doctor to identify missing or extra shims and will request users to run mise reshim if needed.

Additional Notes

Quite a bit of refactoring here really just to make the changes more obvious.
Uses checks rather than a warning, but can be trivially updated to warnings if desired

src/cli/doctor.rs

jdx · 2024-01-25T16:51:25Z

src/shims.rs

-
-    let shims_to_add = shims.difference(&existing_shims);
-    let shims_to_remove = existing_shims.difference(&shims);
+    let (shims_to_add, shims_to_remove) = get_shim_diffs(&mise_bin, ts)?;


I was sure this would need to be refactored, but it looks like it wasn't too bad. I actually refactored this at one point to use the set difference and I think that paid off. Before it just did the calculation and symlink edits at the same time.

jdx · 2024-01-25T16:52:50Z

src/shims.rs

+fn list_tool_bins(t: Arc<dyn Forge>, tv: &ToolVersion) -> Result<Vec<String>> {
+    Ok(t.list_bin_paths(tv)?
+        .into_iter()
+        .par_bridge()


I do wonder if using parallelization is actually worth it for stuff like this. I think maybe if someone had like 100 tools (and I know some people do), it might help.

That said, when I have tried to benchmark stuff like this in the past with rust it's basically impossible to tell the difference at least with hyperfine. I think to really find out we'd have to have isolated benchmarks.

jdx · 2024-01-25T16:54:13Z

also, keep in the back of your mind other potential checks we might be able to add here