Additional arch install #1562
Additional arch install #1562
Conversation
|
there is a script you can use to test this |
| install_path="${MISE_INSTALL_PATH:-$HOME/.local/bin/mise}" | ||
| install_dir="$(dirname "$install_path")" | ||
| tarball_url="https://github.com/jdx/mise/releases/download/${version}/mise-${version}-${os}-${arch}.tar.gz" | ||
| if [ -z "$musl" ]; then | ||
| tarball_url="https://github.com/jdx/mise/releases/download/${version}/mise-${version}-${os}-${arch}-${musl}.tar.gz" |
There was a problem hiding this comment.
I think if you just made musl part of $arch it'll clean up a lot of this logic
There was a problem hiding this comment.
Done. Also made the code to check for musl slightly cleaner.
| if [ -z "$libc" ]; then | ||
| echo "musl" | ||
| else | ||
| echo "" |
There was a problem hiding this comment.
you can just get rid of these else conditions and do nothing
There was a problem hiding this comment.
Got rid of this entirely. Moving the check to get_arch() cleaned things up a bit.
| @@ -46,6 +59,8 @@ get_arch() { | |||
| echo "x64" | |||
| elif [ "$arch" = aarch64 ] || [ "$arch" = arm64 ]; then | |||
| echo "arm64" | |||
| elif [ "$arch" = armv7l ]; then | |||
There was a problem hiding this comment.
go ahead and add "armv6l" idk if it will work, but it's not like not trying to handle it would do anything useful anyways
of course if you want to find a way to test it that's great but I don't really mind
There was a problem hiding this comment.
Ha, I actually thought I had added that earlier, but it's there now.
Took a stab at supporting the additional architectures in the generated install script. I admit I haven't thoroughly tested this by any means and the shell scripting probably leads a lot to be desired, but perhaps it can be a jumping off point, at least.