Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: make missing tool warning more granular #1577

Merged
merged 3 commits into from
Feb 1, 2024
Merged

status: make missing tool warning more granular #1577

merged 3 commits into from
Feb 1, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Jan 31, 2024

by default this will only show when at least 1 version of the tool has been installed

@jdx jdx marked this pull request as ready for review January 31, 2024 23:37
@jdx jdx enabled auto-merge (squash) January 31, 2024 23:37
Copy link

codacy-production bot commented Jan 31, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 89.74%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (de5e5b6) 16268 13672 84.04%
Head commit (a44bb1c) 16299 (+31) 13698 (+26) 84.04% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1577) 39 35 89.74%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@jdx jdx disabled auto-merge January 31, 2024 23:51
@jdx jdx changed the title settings: added some missing settings to settings set status: make missing tool warning more granular Jan 31, 2024
@jdx jdx enabled auto-merge (squash) February 1, 2024 00:11
@jdx jdx merged commit 6c6afe1 into main Feb 1, 2024
9 checks passed
@jdx jdx deleted the settings branch February 1, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants