Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry with https if request fails #1690

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Retry with https if request fails #1690

merged 1 commit into from
Feb 22, 2024

Conversation

grant0417
Copy link
Contributor

@grant0417 grant0417 commented Feb 21, 2024

Port 80 is blocked CI for more security so I am getting the following error:

Error: 
   0: error sending request for url (http://mise-versions.jdx.dev/python-precompiled): error trying to connect: operation timed out
   1: error trying to connect: operation timed out
   2: operation timed out

Location:
   src/http.rs:56

I added the same logic for retying with https as below which would only occur before if the server responded with an error status. Now it should retry even if the net level request fails.

src/http.rs Outdated Show resolved Hide resolved
@jdx jdx merged commit 3417560 into jdx:main Feb 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants