Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep RUBYLIB env var #2387

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix: keep RUBYLIB env var #2387

merged 1 commit into from
Jul 19, 2024

Conversation

jdx
Copy link
Owner

@jdx jdx commented Jul 19, 2024

This should not be necessary anymore now that ruby is a core plugin.

Fixes #2380

This should not be necessary anymore now that ruby is a core plugin.

Fixes #2380
@jdx jdx enabled auto-merge (squash) July 19, 2024 02:15
Copy link

Code Coverage

Package Line Rate Complexity Health
src.backend 69% 0
src 86% 0
src.cli 83% 0
src.cli.alias 89% 0
src.cli.args 97% 0
src.cli.backends 95% 0
src.cli.cache 95% 0
src.cli.config 92% 0
src.cli.direnv 80% 0
src.cli.generate 87% 0
src.cli.plugins 86% 0
src.cli.settings 93% 0
src.cli.sync 27% 0
src.cli.tasks 71% 0
src.config.config_file 89% 0
src.config 87% 0
src.plugins 90% 0
src.plugins.core 56% 0
src.shell 98% 0
src.toolset 86% 0
src.ui 63% 0
Summary 80% (13685 / 17038) 0

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a897efa) 17039 13686 80.32%
Head commit (52158d8) 17038 (-1) 13685 (-1) 80.32% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#2387) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx merged commit 63afb43 into main Jul 19, 2024
12 checks passed
@jdx jdx deleted the rubylib branch July 19, 2024 02:23
triarius pushed a commit to triarius/mise that referenced this pull request Sep 18, 2024
This should not be necessary anymore now that ruby is a core plugin.

Fixes jdx#2380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mise wipe RUBYLIB value when working with RubyMine
1 participant