-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: mise hints #2479
feat: mise hints #2479
Conversation
I like the *! |
0680219
to
b9b8b95
Compare
I think a great addition to this would be the current warning about precompiled python binaries which is probably annoying to people that already are aware of its limitations |
@@ -31,6 +31,14 @@ | |||
"description": "disables built-in shorthands", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can actually probably just remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was already wondering if this is still useful since all settings can also be part of .mise.toml
7417675
to
2793296
Compare
@jdx tried to disable the hints for the tests but one test keeps failing and i can't figure out why. it passes in my IDE and when run via cargo test but not via nextest.
|
Is it just me or does this feel a bit annoying and intrusive? How would we educate users about disabling the hints? |
e00e9e5
to
21321f7
Compare
warn!("if you experience issues with this python (e.g.: running poetry), switch to python-build"); | ||
warn!("by running: mise settings set python_compile 1"); | ||
hint!( | ||
"install", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i wonder if we need more fine grained control here
2432fc2
to
922b600
Compare
yeah I think we should show a second line like: |
it's a bit unfortunate that array settings are not additive, so we need to include existing settings |
yeah maybe at some point we could add a |
First draft for a very pragmatic approach on mise hints. Just adds a simple
hint!
macro with static args which respects the setting. Since i wasn't able to figure out yet how to have a multi-type setting i thought it might be handy to usedisable_hints= ["*"]
as a way to disable all commands (IIRC we use*
for running all tasks as well?)It might be nicer to have something which we could pin to the run method such as
#[hint(...)]
(derive, proc_macro?). Not sure if Rust has something similar to Aspects in Java which allows you to run stuff after/before method calls etc.Still a bit undecided about the styling. We probably should stick to a
dim
prefix like info messages but should highlight the command somehow withbold
?Fixes #2460