Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: fixed --help flag, added "s" alias #976

Merged
merged 1 commit into from
Nov 8, 2023
Merged

shell: fixed --help flag, added "s" alias #976

merged 1 commit into from
Nov 8, 2023

Conversation

jdx
Copy link
Owner

@jdx jdx commented Nov 3, 2023 •
edited
Loading

Fixes #952
Fixes #711

@jdx jdx linked an issue Nov 3, 2023 that may be closed by this pull request
rtx shell -h (or --help) is broken #952
Closed
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (231e1d0) 87.41% compared to head (febd7a7) 87.42%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #976      +/-   ##
==========================================
+ Coverage   87.41%   87.42%   +0.01%     
==========================================
  Files         132      132              
  Lines       11613    11629      +16     
==========================================
+ Hits        10151    10167      +16     
  Misses       1462     1462
Files Coverage Δ
src/cli/shell.rs 95.23% <ø> (ø)
src/shell/bash.rs 100.00% <100.00%> (ø)
src/shell/fish.rs 100.00% <100.00%> (ø)
src/shell/zsh.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdx jdx changed the title shell: fixed -h,--help flag shell: fixed --help flag, added "s" alias Nov 3, 2023
@jdx jdx enabled auto-merge (squash) November 3, 2023 23:01
This was referenced Nov 3, 2023
Closed
Closed
@jdx jdx merged commit 8ec558a into main Nov 8, 2023
14 checks passed
@jdx jdx deleted the shell branch November 8, 2023 18:14
jdx pushed a commit that referenced this pull request Apr 9, 2024
@stephane-klein @jthegedus
feat: add typst plugin (#974) (#976)
5afe7b5 
Co-authored-by: James Hegedus <jthegedus@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rtx shell -h (or --help) is broken different behaviors for rtx global local shell
1 participant
@jdx