You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In https://bugzilla.mozilla.org/show_bug.cgi?id=1125464#c8 it was found that we were using the master_host for everything, even though we had thought we had specified read_host for the appropriate selects in the SQL proc file.
Unfortunately it turned out we were using the property 'host' rather than 'host_type'., eg:
"get_performance_series": {
"sql":"SELECT `interval_seconds`, `series_signature`, `type`, `last_updated`, `blob` FROM `performance_series` WHERE `interval_seconds` = ? AND `series_signature` = ?",
"host":"read_host"
},
This issue would have been much easier to spot, if Datasource validated the keys and rejected any that it did not recognise.
Alternatively, if that is not something you wish to do - having a way to opt out of the default_host_type would mean we could catch any cases where we were not explicitly passing the desired host_type (possibly a good feature in its own right).
The text was updated successfully, but these errors were encountered:
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this issue
Jan 24, 2015
The 'host' property is unrecognised (and ignored) by Datasource, causing
it to silently fall back to the default of 'master_host'. The property
we needed to have set is in fact called 'host_type'.
As a result, we never use the read-only host!
An issue has been filed against Datasource for making this less silent:
jeads/datasource#20
edmorley
pushed a commit
to mozilla/treeherder
that referenced
this issue
Jan 24, 2015
The 'host' property is unrecognised (and ignored) by Datasource, causing
it to silently fall back to the default of 'master_host'. The property
we needed to have set is in fact called 'host_type'.
As a result, we never use the read-only host!
An issue has been filed against Datasource for making this less silent:
jeads/datasource#20
In https://bugzilla.mozilla.org/show_bug.cgi?id=1125464#c8 it was found that we were using the master_host for everything, even though we had thought we had specified read_host for the appropriate selects in the SQL proc file.
Unfortunately it turned out we were using the property 'host' rather than 'host_type'., eg:
This issue would have been much easier to spot, if Datasource validated the keys and rejected any that it did not recognise.
Alternatively, if that is not something you wish to do - having a way to opt out of the default_host_type would mean we could catch any cases where we were not explicitly passing the desired host_type (possibly a good feature in its own right).
The text was updated successfully, but these errors were encountered: