kernel_netlink: Convert src_plen to v4mapped encoding on import #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src_plen for IPv4 routes imported from kernel has not been adjusted to v4mapped encoding. Therefore IPv4 xroutes used an inconsistent encoding which lead to failed comparisons when sending updates. Routes received from neighbors with the same prefix as xroutes therefore have been announced to neighbours instead. This issue is fixed by converting src_plen on import. Signed-off-by: Fabian Bläse <fabian@blaese.de>
|
LGTM! I think I've seen this behavior. |
|
this appears corrct to me. @jech ?? |
|
Thanks, applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src_plen for IPv4 routes imported from kernel has not been adjusted
to v4mapped encoding. Therefore IPv4 xroutes used an inconsistent encoding
which lead to failed comparisons when sending updates.
Routes received from neighbors with the same prefix as xroutes therefore
have been announced to neighbours instead.
This issue is fixed by converting src_plen on import.
Signed-off-by: Fabian Bläse fabian@blaese.de