Remove src_plen assignments which break v4mapped encoding #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These assignments were introduced in f8bce04, probably to ensure that src_plen doesn't contain any leftovers from earlier revisions when source specific wasn't done via sub-TLVs. This however breaks v4mapped encoding as a prefix length of 0 for IPv4 routes is represented as src_plen = 96. This offset is already added outside of the affected functions and therefore gets overwritten by this assignment. Both functions contain an additional check if the message contains ipv4 addresses, but as this check is only executed if the message has a source-specific sub-TLV, the offset isn't added for non source-specific routes. Because the offset is already added outside of the subtlv parsing functions, this additional check is also removed, as it would otherwise break IPv4 source specifics by adding the IPv4 offset two times. Signed-off-by: Fabian Bläse <fabian@blaese.de>
|
There was a bug indeed, I've committed a different fix in 079bea9. Please let me know if there are any issues remaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These assignments were introduced in f8bce04, probably
to ensure that src_plen doesn't contain any leftovers from
earlier revisions when source specific wasn't done via sub-TLVs.
This however breaks v4mapped encoding as a prefix length of 0
for IPv4 routes is represented as src_plen = 96. This offset is
already added outside of the affected functions and therefore
gets overwritten by this assignment.
Both functions contain an additional check if the message contains
ipv4 addresses, but as this check is only executed if the message has
a source-specific sub-TLV, the offset isn't added for non source-specific
routes.
Because the offset is already added outside of the subtlv parsing
functions, this additional check is also removed, as it would otherwise
break IPv4 source specifics by adding the IPv4 offset two times.
Signed-off-by: Fabian Bläse fabian@blaese.de