Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message when firefox can't start webrtc #51

Closed
mscherer opened this issue Feb 1, 2021 · 1 comment
Closed

Better error message when firefox can't start webrtc #51

mscherer opened this issue Feb 1, 2021 · 1 comment

Comments

@mscherer
Copy link

mscherer commented Feb 1, 2021

If one disable webrtc (about:config => media.peerconnection.enabled set to false), galene will silently fail with a error in the web console:

Uncaught (in promise) ReferenceError: RTCPeerConnection is not defined
    newUpStream https://galene.example.org/protocol.js:406
    newUpStream https://galene.example.org/galene.js:779
    addLocalMedia https://galene.example.org/galene.js:1066

This setting is documented on https://wiki.mozilla.org/Media/WebRTC/Privacy

While that's not a default configuration, some people disable Webrtc for privacy (with https://addons.mozilla.org/en-US/firefox/addon/happy-bonobo-disable-webrtc/ , and afaik, the Tor browser do it).

mscherer added a commit to mscherer/galene that referenced this issue Feb 1, 2021
@jech
Copy link
Owner

jech commented Feb 14, 2021

Fixed in e04193f

@jech jech closed this as completed Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants