New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape CSV data that needs escaping #26

Merged

jecovier merged 1 commit into jecovier:master from dan24678:master

Jan 2, 2018

dan24678 commented Dec 28, 2017

Per #25 CSV data should be treated as follows:

If the value contains a comma, newline or double quote, then the String value should be returned enclosed in double quotes.
Any double quote characters in the value should be escaped with another double quote.
If the value does not contain a comma, newline or double quote, then the String value should be returned unchanged.


          Escape CSV data that needs escaping

57dbdde

dan24678 mentioned this pull request

CSV Export Won't Escape Commas #25

Closed

jecovier merged commit 36208a8 into jecovier:master

Owner

jecovier commented Jan 2, 2018

@DrLongGhost Thank you for this fix, I had not thought about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet