This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Allow repository to be used from $NODE_PATH #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'd rather fix this properly than use a hacky symlink... would you mind trying the |
|
Yup, seems to work fine: https://github.com/gfxmonk/dynamo/tree/rename |
jed
added a commit
that referenced
this pull request
Jun 26, 2012
Allow repository to be used from $NODE_PATH
|
cool, merged. thanks, @gfxmonk. |
|
Erm, didn't you prefer the rename solution? Looks like you've merged the symlink. |
|
blarg, can you set up another PR from the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a toplevel directory called "lib" means you can't put a repository checkout on $NODE_PATH and be able to require("dynamo").
I've added a symlink that enables this, although it would be perfectly reasonable (but a little more effort) to rename "lib" -> "dynamo".
I need this because I don't use
npm, and would rather not have to maintain a fork of this project just to change the toplevel directory name.