Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding batch display on enter #325

Closed
wants to merge 2 commits into from

Conversation

jeff06
Copy link

@jeff06 jeff06 commented Jul 30, 2024

If outputmirror is set, and there is a batchsize that has been set (SetBatchSize(6)), element will be displayed according to this. This exclude header and footer.

@coveralls
Copy link

coveralls commented Jul 30, 2024

Pull Request Test Coverage Report for Build 10169684130

Details

  • 5 of 22 (22.73%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 99.524%

Changes Missing Coverage Covered Lines Changed/Added Lines %
table/table.go 5 22 22.73%
Totals Coverage Status
Change from base Build 8953482681: -0.5%
Covered Lines: 3557
Relevant Lines: 3574

💛 - Coveralls

Copy link

sonarcloud bot commented Jul 30, 2024

@jeff06 jeff06 mentioned this pull request Jul 30, 2024
@jedib0t
Copy link
Owner

jedib0t commented Jul 31, 2024

Thanks for the contribution. But I feel there may be a better way to do this without changing existing interfaces. Give me a few days to think about this. Busy with real world stuff. :(

@jeff06
Copy link
Author

jeff06 commented Aug 17, 2024

Hello,

Hope everything is ok.
I was Curious about the status of this PR.

Thank,

@jedib0t
Copy link
Owner

jedib0t commented Aug 20, 2024

Hey really sorry about the delay. I started working on an alternate implementation last week that would give you a "Pager" which will let you go back and forth in pages. But I never got around to completing it due to personal reasons. I promise to get back to you by this weekend. 🤞

@jedib0t
Copy link
Owner

jedib0t commented Sep 1, 2024

Hey @jeff06 sorry for the delay. I've pushed an initial draft of my changes to the pager branch @ https://github.com/jedib0t/go-pretty/tree/pager. Specific commit: d2e7d24 -- please take a look and let me know if this serves your purpose. I'll then merge it to the main branch.

@jeff06
Copy link
Author

jeff06 commented Sep 12, 2024

Hi, Yes it does, thank you so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants