Admin history/view for non-admin views (issue #46) #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Refactor admin.py by extracting common code between admin and non-admin view and putting it to two new modules: mixins.py (for view mixins) and compare.py (for compare objects) * Implement a HistoryCompareDetailView CBV that can be used as a normal DetailView to both display the history and select-version-form *and* the changes of the selected versions * Fix tests so that they run under windows and add test for CBV (by copying the tests for the SimpleModel -- probably this could be refactored a bit) * Update README and AUTOHRS
|
Thanks for contribution! Travis tests failed with Python 3: https://travis-ci.org/jedie/django-reversion-compare/jobs/81554176#L298-L300 |
|
@jedie should be ok now I'd forgot to run the tests with python 3 ! |
|
|
||
| Beyond the admin views, you can also create a class based view for displaying and comparing version | ||
| differences. This is a single class-based-view that either dispalys the list of versions to select | ||
| for an object or displays both the versions *and* their differences (if the versions to be compared |
|
Everything should be ok now - sorry I wasn't really familiar with creole syntax :( |
jedie
added a commit
that referenced
this pull request
Sep 22, 2015
Admin history/view for non-admin views (issue #46) - contributed by Papastefanos, Serafeim
|
I will check this soon and create a new release. Thanks for contributing! |
|
release as v0.5.6: https://pypi.python.org/pypi/django-reversion-compare/0.5.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: