Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 1.9 and Python 3 support #9

Merged
merged 26 commits into from
Apr 27, 2016
Merged

Conversation

naegelyd
Copy link

@naegelyd naegelyd commented Apr 2, 2016

@jedie

This PR adds support for Django 1.9 and drops support for Django < 1.8. From the tests alone, there does not appear to be any issue with Django 1.9. In addition, this PR does some general cleanup including but not limited to:

  • Adding a toxfile for local testing
  • Adding flake8 as part of the test process
  • Ignoring some IDE specific files

Additionally, this PR fixes all the broken tests as best I could figure them and adds Python 3 support. While the test coverage is still not that high, all tests are passing on this PR.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c924ee7 on naegelyd:django-1.9-support into * on jedie:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d0a720e on naegelyd:django-1.9-support into * on jedie:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 22c23b8 on naegelyd:django-1.9-support into * on jedie:master*.

flake8 doesn't seem to be able to figure out that this is only for Python 2.7 code.
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling c8fc8b2 on naegelyd:django-1.9-support into * on jedie:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6f0a182 on naegelyd:django-1.9-support into * on jedie:master*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8350488 on naegelyd:django-1.9-support into * on jedie:master*.

@naegelyd naegelyd changed the title Django 1.9 support Django 1.9 and Python 3 support Apr 2, 2016
@jedie jedie self-assigned this Apr 2, 2016
@jedie
Copy link
Owner

jedie commented Apr 2, 2016

Cool! I will take a look at this this week.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3164ec2 on naegelyd:django-1.9-support into * on jedie:master*.

deps =
coverage == 4.0.3
django18: Django==1.8.12
django19: Django==1.9.5
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no way to say: Django==1.9.x ?!?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Let me update these to use ranges.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedie
Copy link
Owner

jedie commented Apr 4, 2016

Thanks for the contribution!

A little bit boring is the mix of code changes and code-format/whitespace changes :(

Do you see a way to split code changes from format changes?!?

@naegelyd
Copy link
Author

naegelyd commented Apr 4, 2016

Do you see a way to split code changes from format changes?!?

Sure, I can squash the lint related commits to a single change and then you can decide whether to include it in this PR, include it in a different PR, or discard it altogether.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling af045a0 on naegelyd:django-1.9-support into * on jedie:master*.

@jedie
Copy link
Owner

jedie commented Apr 4, 2016

Squash all lint related commits, is a good idea!

The import is unused and will cause failures on Django 1.9
@naegelyd
Copy link
Author

naegelyd commented Apr 4, 2016

@jedie Thanks for the quick review. As much as possible, I have removed lint changes from this PR and removed the flake8 step from tox and travis files. The diff is now much smaller and, I think, manageable. I cherrypicked the changes onto a different local branch so I can submit a followup PR if you would like to add flake8 to the test pipeline and include those changes there. Some changes(like trailing whitespace removal) were included in other commits and I've left them in because of the difficulty in separating them but I think given the new diff size, that this might be OK.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9be86fc on naegelyd:django-1.9-support into * on jedie:master*.

@naegelyd
Copy link
Author

@jedie - Friendly ping

@jedie jedie merged commit e014f69 into jedie:master Apr 27, 2016
@jedie
Copy link
Owner

jedie commented Apr 27, 2016

Thanks for the ping ;)

@jedie
Copy link
Owner

jedie commented Apr 27, 2016

I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0

@naegelyd
Copy link
Author

I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0

Awesome. Thanks @jedie!

@naegelyd naegelyd deleted the django-1.9-support branch April 27, 2016 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants