-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django 1.9 and Python 3 support #9
Conversation
These tests were broken from the changes in ce2de9b
Changes Unknown when pulling c924ee7 on naegelyd:django-1.9-support into * on jedie:master*. |
Changes Unknown when pulling d0a720e on naegelyd:django-1.9-support into * on jedie:master*. |
6548548
to
5d72b4a
Compare
5d72b4a
to
22c23b8
Compare
Changes Unknown when pulling 22c23b8 on naegelyd:django-1.9-support into * on jedie:master*. |
flake8 doesn't seem to be able to figure out that this is only for Python 2.7 code.
Changes Unknown when pulling c8fc8b2 on naegelyd:django-1.9-support into * on jedie:master*. |
Changes Unknown when pulling 6f0a182 on naegelyd:django-1.9-support into * on jedie:master*. |
Changes Unknown when pulling 8350488 on naegelyd:django-1.9-support into * on jedie:master*. |
Cool! I will take a look at this this week. |
Changes Unknown when pulling 3164ec2 on naegelyd:django-1.9-support into * on jedie:master*. |
deps = | ||
coverage == 4.0.3 | ||
django18: Django==1.8.12 | ||
django19: Django==1.9.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there no way to say: Django==1.9.x
?!?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Let me update these to use ranges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! A little bit boring is the mix of code changes and code-format/whitespace changes :( Do you see a way to split code changes from format changes?!? |
Sure, I can squash the lint related commits to a single change and then you can decide whether to include it in this PR, include it in a different PR, or discard it altogether. |
Changes Unknown when pulling af045a0 on naegelyd:django-1.9-support into * on jedie:master*. |
This reverts commit dc9c4bc.
Squash all lint related commits, is a good idea! |
The import is unused and will cause failures on Django 1.9
@jedie Thanks for the quick review. As much as possible, I have removed lint changes from this PR and removed the |
Changes Unknown when pulling 9be86fc on naegelyd:django-1.9-support into * on jedie:master*. |
@jedie - Friendly ping |
Thanks for the ping ;) |
I upload the new v0.30.0 release: https://pypi.python.org/pypi/django-tools/0.30.0 |
Awesome. Thanks @jedie! |
@jedie
This PR adds support for Django 1.9 and drops support for Django < 1.8. From the tests alone, there does not appear to be any issue with Django 1.9. In addition, this PR does some general cleanup including but not limited to:
flake8
as part of the test processAdditionally, this PR fixes all the broken tests as best I could figure them and adds Python 3 support. While the test coverage is still not that high, all tests are passing on this PR.