Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front-end should be containerised using Docker #10

Closed
jedster1111 opened this issue Jun 18, 2019 · 0 comments · Fixed by #18
Closed

Front-end should be containerised using Docker #10

jedster1111 opened this issue Jun 18, 2019 · 0 comments · Fixed by #18
Assignees
@jedster1111
Labels
CI docker

Comments

@jedster1111
Copy link
Owner

jedster1111 commented Jun 18, 2019 •
edited
Loading

AC:

  • Should use NGINX to serve the static artefacts generated using the build command from Create-React-App.
  • Should only contain the static files, not all of the development files as well.
  • Should expose the port 80.
  • Documentation on building and running the image should be added to the README file.
@jedster1111 jedster1111 mentioned this issue Jun 19, 2019
Open
@jedster1111 jedster1111 self-assigned this Jun 19, 2019
jedster1111 pushed a commit that referenced this issue Jun 19, 2019
GH-10 Frontend containerised & served using NGINX
1ef8474
jedster1111 pushed a commit that referenced this issue Jun 19, 2019
GH-10 Frontend containerised & served using NGINX
7bb42c2
@jedster1111 jedster1111 mentioned this issue Jun 19, 2019
Merged
jedster1111 pushed a commit that referenced this issue Jun 23, 2019
GH-10 Updated stop container command in README
9d35861
jedster1111 pushed a commit that referenced this issue Jun 23, 2019
GH-10 update Dockerfile COPY to look for yarn.lock
e4150c6
jedster1111 pushed a commit that referenced this issue Jun 23, 2019
GH-10 Added command to attach to docker container
afd917a
jedster1111 pushed a commit that referenced this issue Jun 23, 2019
GH-10 Updated detach from docker container command
154dc39
tonyt50 added a commit that referenced this issue Jun 23, 2019
@tonyt50
Merge pull request #18 from jedster1111/GH-10
4a101e6 
GH-10 Frontend containerised & served using NGINX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedster1111 jedster1111

Labels
CI docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-10 Frontend containerised & served using NGINX jedster1111/bananagram-mk2
1 participant
@jedster1111