Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm scripts vs Cordova hooks -- for build stage #1

Closed
devgeeks opened this issue Feb 4, 2016 · 3 comments
Closed

npm scripts vs Cordova hooks -- for build stage #1

devgeeks opened this issue Feb 4, 2016 · 3 comments
Assignees

Comments

@devgeeks
Copy link
Collaborator

devgeeks commented Feb 4, 2016

Working on splitting a PhoneGap / Cordova template out from the app and couldn't remember our conversation about using npm scripts vs using Cordova hooks.

Do you remember why you went that way in the end?

@JedWatson
Copy link
Owner

There was a pretty strong sentiment that said "don't use hooks" from a couple of people at the conference - also the npm scripts are pretty simple, and consistent (e.g using npm start to run in dev mode w/o using cordova at all)

Is there any argument for using cordova hooks? Happy to change if it's a better user experience.

@devgeeks
Copy link
Collaborator Author

devgeeks commented Feb 5, 2016

I think just in terms of a template (as opposed to an example app), hooks mean users just use the commands they know like cordova build ios, etc. Instead of having to learn commands specific to the template.

Having said that, we did come across some issues with running a long-running process like the hot reloading server.

sigh

Let me play with it and see what I can come up with.

My plan is to work on the template initially as a branch to this app, then split it off. I assume you don't want to maintain it, but it's important for the git history to remain and have your authorship be clear.

@devgeeks devgeeks assigned devgeeks and unassigned JedWatson Feb 5, 2016
@devgeeks
Copy link
Collaborator Author

I left it as is. No hooks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants