Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] setting background color with aspect-ratio=keep #52

Closed
jeertmans opened this issue Oct 19, 2022 · 8 comments · Fixed by #60
Closed

[FEATURE] setting background color with aspect-ratio=keep #52

jeertmans opened this issue Oct 19, 2022 · 8 comments · Fixed by #60
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue that is created for the Hacktoberfest event

Comments

@jeertmans
Copy link
Owner

Description

When using aspect-ratio=keep, the background color is white.
However, this might look weird on presentations with, e.g., black background color.

I propose to add a background color option in the CLI, that defaults to black.

Screenshots

The goal is to change the color of the borders.

image

Example of desired output with background-color=black:

image

Additional information

All the changes should occur in manim_slides/present.py.

First, create a new keyword argument to App.__init__ called

background_color: str = "black"

Then, after self.label = QLabel(self), write

self.label.setStyleSheet(f"background-color: {background_color}")

After that, you need to add a new argument to the CLI (see @click.option) and pass it to the App instance.

@jeertmans jeertmans added enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue that is created for the Hacktoberfest event labels Oct 19, 2022
@Anmol-Ghadia
Copy link

Hi, can I be assigned to this issue?

@jeertmans
Copy link
Owner Author

Hi, of course @Anmol-Ghadia!
I am glad you are interested in helping this project :D

@jeertmans
Copy link
Owner Author

Hi @Anmol-Ghadia, still working on this?

@Anmol-Ghadia
Copy link

Hi, I am so sorry for taking so long. If possible can you give me few more days to try it?

@jeertmans
Copy link
Owner Author

Yes of course @Anmol-Ghadia!

@Anmol-Ghadia
Copy link

Hi, I am really sorry. I will not be able to complete this feature. You can remove me from assigned. Thank you for your patience and understanding.

@jeertmans
Copy link
Owner Author

No problem @Anmol-Ghadia ;)
I’ll probably work on this and create a PR. If you are interested, I can tag you so that you see how you could have done that?

jeertmans added a commit that referenced this issue Oct 31, 2022
This allows to define the background color used for border when resize mode is set to "keep".

Closes #52
@jeertmans
Copy link
Owner Author

Hi @Anmol-Ghadia, you can check #60 to see what I was roughly expecting with this issue ;-)

If you want to try adding another feature, please feel free to propose!

jeertmans added a commit that referenced this issue Oct 31, 2022
* feat: add option for background color

This allows to define the background color used for border when resize mode is set to "keep".

Closes #52

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue that is created for the Hacktoberfest event
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants