-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] setting background color with aspect-ratio=keep
#52
Comments
Hi, can I be assigned to this issue? |
Hi, of course @Anmol-Ghadia! |
Hi @Anmol-Ghadia, still working on this? |
Hi, I am so sorry for taking so long. If possible can you give me few more days to try it? |
Yes of course @Anmol-Ghadia! |
Hi, I am really sorry. I will not be able to complete this feature. You can remove me from assigned. Thank you for your patience and understanding. |
No problem @Anmol-Ghadia ;) |
This allows to define the background color used for border when resize mode is set to "keep". Closes #52
Hi @Anmol-Ghadia, you can check #60 to see what I was roughly expecting with this issue ;-) If you want to try adding another feature, please feel free to propose! |
* feat: add option for background color This allows to define the background color used for border when resize mode is set to "keep". Closes #52 * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
When using
aspect-ratio=keep
, the background color is white.However, this might look weird on presentations with, e.g., black background color.
I propose to add a background color option in the CLI, that defaults to black.
Screenshots
The goal is to change the color of the borders.
Example of desired output with
background-color=black
:Additional information
All the changes should occur in
manim_slides/present.py
.First, create a new keyword argument to
App.__init__
calledThen, after
self.label = QLabel(self)
, writeAfter that, you need to add a new argument to the CLI (see
@click.option
) and pass it to theApp
instance.The text was updated successfully, but these errors were encountered: