-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chromium sandbox skipping #209
Conversation
c86b643
to
1126683
Compare
I really like this! Although, I think Thanks! |
Sure, I've added the |
Agreed! Sorry, I wasn't clear there, but it all looks good from here! Thank you!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
I don't necessarily want to start managing a Dockerfile quite yet because it'll open another can of worms, so this is a great start for those interested.
Thanks!
This PR adds an optional environment variable TRUSTED which can be used to skip puppeteer/chromium's sandbox usage, it defaults to false. Relates to #114 but our approach is slightly different, i.e. this change does not force the insecure setting unless set by the user.
Edit: linking to sample Docker usage using an image pushed to the DockerHub registry: https://github.com/andrewmackrodt/dockerfiles/tree/master/nvidia-snatcher#docker