Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Zotac for store, Nvidia cartUrl temp fix, Readme update, Newegg/Amazon Captcha workaround, .env.example commented #50

Closed
wants to merge 26 commits into from
Closed

Adding Zotac for store, Nvidia cartUrl temp fix, Readme update, Newegg/Amazon Captcha workaround, .env.example commented #50

wants to merge 26 commits into from

Conversation

geman220
Copy link
Contributor

@geman220 geman220 commented Sep 19, 2020 •
edited
Loading

Description

  • Adding Zotac store configurable by zotac in .env
  • Adding cartUrl for Nvidia so that API success opens a URL to buy instead of the API result URL
  • Updating Readme to show Zotac support
  • Added Captcha workaround for Amazon/Newegg looks for text 'Enter the characters you see below' and 'Are you a human?' respectfully to stops false positives
  • Commented out .env.example to make the process a bit easier. Users can rename .env.example to .env without impacting anything. Add explainations for each .env variable and user can comment out what they do or do not want to use. For example, several users don't use Slack and the API attempt to connect are throwing up errors. Disabling by default would remove the extra process and errors.

Testing

New dependencies

@geman220 geman220 requested a review from jef as a code owner September 19, 2020 02:37
@geman220 geman220 changed the title Adding Zotac for store as well as readme update Adding Zotac for store, Nvidia Store fix, Readme update Sep 19, 2020
@geman220 geman220 changed the title Adding Zotac for store, Nvidia Store fix, Readme update Adding Zotac for store, Nvidia Store fix, Readme update, Newegg Captcha workaround Sep 19, 2020
@geman220 geman220 changed the title Adding Zotac for store, Nvidia Store fix, Readme update, Newegg Captcha workaround Adding Zotac for store, Nvidia Store fix, Readme update, Newegg/Amazon Captcha workaround Sep 19, 2020
karthshen
karthshen previously approved these changes Sep 19, 2020
View reviewed changes
@geman220 geman220 changed the title Adding Zotac for store, Nvidia Store fix, Readme update, Newegg/Amazon Captcha workaround Adding Zotac for store, Nvidia Store fix, Readme update, Newegg/Amazon Captcha workaround, .env.example commented Sep 19, 2020
@geman220 geman220 mentioned this pull request Sep 19, 2020
Closed
@geman220 geman220 changed the title Adding Zotac for store, Nvidia Store fix, Readme update, Newegg/Amazon Captcha workaround, .env.example commented Adding Zotac for store, Nvidia cartUrl temp fix, Readme update, Newegg/Amazon Captcha workaround, .env.example commented Sep 19, 2020
jef
jef requested changes Sep 19, 2020
View reviewed changes
.env.example
// All configuration variables are OPTIONAL. Uncomment any variables you wish to use or use none of them!
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this type of documentation should live inside the README. In my opinion, it's descriptive enough, but if we want extra help documentation, let's put it inside the wiki.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, we can remove it. I just know a lot of people in discord are renaming the .env.example without modifying anything inside of the .env and they are getting lots of errors because they haven't filled in API information etc.

src/store/nvidia.ts
@@ -1,7 +1,7 @@
import {Store} from './store';

export const Nvidia: Store = {
cartUrl: '',
cartUrl: 'https://www.nvidia.com/en-us/shop/geforce/?page=1&limit=9&locale=en-us&gpu=RTX%203080&gpu_filter=RTX%203090~1,RTX%203080~7,RTX%203070~1,TITAN%20RTX~1,RTX%202080%20Ti~2,RTX%202080%20SUPER~16,RTX%202080~5,RTX%202070%20SUPER~26,RTX%202070~15,RTX%202060%20SUPER~7,RTX%202060~36,GTX%201660%20Ti~29,GTX%201660%20SUPER~4,GTX%201660~11,GTX%201650%20Ti~6,GTX%201650%20SUPER~8,GTX%201650~34',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't actually a cart, I think we should remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The potential problem here is that even if Nvidia is detected in stock, it will open the API result on Digital River. That doesn't really help anyone purchase a card, the previous cartUrl doesn't work any longer so this at least brings you to a page where you can purchase a card.

src/store/zotac.ts
{
brand: 'zotac',
model: 'trinity',
url: 'https://store.zotac.com/zotac-gaming-geforce-rtx-3080-trinity-zt-a30800d-10p',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zotac store is down and has a lot of catchpa right now. I'd suggest updating the oosLabels.

@geman220 geman220 closed this Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jef jef jef requested changes

@karthshen karthshen karthshen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geman220 @jef @karthshen