-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): correcting newline split for multiple user agents #824
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh awesome. Thank you very much for catching this bug!
Thanks for trying! |
Yeah, we can do that! Makes sense to me. |
Awesome, go ahead and revert this out @jef and I'll get a new PR going for either handling unquoted + quoted or just document that everything should be quoted 😄 |
Based off #824 Signed-off-by: Jef LeCompte <jeffreylec@gmail.com>
Done! Should be available now on |
Thanks @jef! Sorry about not catching that edge case. |
No problem! Thanks for being it up. |
Description
When using multiple strings split by
\n
forUSER_AGENT
, user agents end up being split by,
due to\n
not being escaped properly.Testing
Given the following in
.env
:config.userAgents
becomes:After this proposed fix,
config.userAgents
becomes:]
New dependencies