Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable name highlighting wrong within curly braces #57

Closed
bland328 opened this issue Mar 21, 2023 · 2 comments
Closed

Variable name highlighting wrong within curly braces #57

bland328 opened this issue Mar 21, 2023 · 2 comments

Comments

@bland328
Copy link

The code with a problem is:

VAR1="$VAR2"	# correct
VAR1="${VAR2}"	# incorrect

It looks like:

Screenshot 2023-03-21 at 10 45 03 AM

It should look like:

${VAR2} should be highlighted like $VAR.

@jeff-hykin
Copy link
Owner

This is what it looks like for me. Are you on the latest version?
Screen Shot 2023-03-21 at 1 59 03 PM

@bland328
Copy link
Author

bland328 commented Mar 28, 2023

The latest version did fix this (and so many other issues that I was preparing to downgrade VS Code), so thanks very much!

I wasn't using the latest version because I didn't understand that there was such a thing, and here's why:

I first reported a highlighting issue at microsoft/vscode#177621, and it was moved here with the explanation that "We switched to a better maintained shell script syntax highlighting grammar recently and we're still working out the bugs."

So, I came here and started reporting other bugs without understanding that better-shell-syntax is not just built into VS Code, but is also an installable extension that might be superior to what's built-in.

Assuming I really do understand the situation correctly, perhaps a prominent "if you are here to report issues, make sure you've manually installed the extension" message at the top of both README.md and the Bug Report template would save both you and naive users like me some pain :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants