Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all '/register' fields not null on registration #3052

Closed
jeff1evesque opened this issue Oct 13, 2017 · 1 comment
Closed

Ensure all '/register' fields not null on registration #3052

jeff1evesque opened this issue Oct 13, 2017 · 1 comment
Labels
bug frontend unit test
Milestone
0.6

Comments

@jeff1evesque
Copy link
Owner

We need to ensure when a user /register, that all fields must be a nonempty string. This means, we'll likely need to adjust our pure javascript validators, and potentially ensure the backend similarly validates.
@jeff1evesque jeff1evesque added this to the 0.6 milestone Oct 13, 2017
@jeff1evesque jeff1evesque mentioned this issue Oct 13, 2017
Closed
jeff1evesque added a commit that referenced this issue Oct 14, 2017
@jeff1evesque
#3052: register.jsx, frontend validate fields
18f1497
jeff1evesque added a commit that referenced this issue Oct 14, 2017
@jeff1evesque
#3052: implement backend 'isValidEmail'
efb9b00
@jeff1evesque
Copy link
Owner Author

We've added the unit test label, since we've added email validation on the backend.

@jeff1evesque jeff1evesque mentioned this issue Oct 14, 2017
Merged
jeff1evesque added a commit that referenced this issue Oct 14, 2017
@jeff1evesque
#3052: fix pytest indentation
90ce6a7
jeff1evesque added a commit that referenced this issue Oct 14, 2017
@jeff1evesque
#3052: register.jsx, dispatch in 'handleSubmit'
bc86c4c
jeff1evesque added a commit that referenced this issue Oct 14, 2017
@jeff1evesque
#3052: register.jsx, move dispatch after 'if'
46ab6ba
jeff1evesque added a commit that referenced this issue Oct 15, 2017
@jeff1evesque
#3052: email.py, replace '==' with 'is'
60fc397
jeff1evesque added a commit that referenced this issue Oct 15, 2017
@jeff1evesque
#3052: register.jsx, remove spinner on error
fcac67c
jeff1evesque added a commit that referenced this issue Oct 15, 2017
@jeff1evesque
#3052: register.jsx, invalid value stops spinner
a3bdd04
jeff1evesque added a commit that referenced this issue Oct 15, 2017
@jeff1evesque
#3052: email.py, fix docstring typo
b2a0489
jeff1evesque added a commit that referenced this issue Oct 15, 2017
@jeff1evesque
Merge pull request #3059 from jeff1evesque/bug-3052
08e6a1f 
#3052: Ensure all '/register' fields not null
jeff1evesque added a commit that referenced this issue Oct 16, 2017
@jeff1evesque
#3052: implement backend 'isValidEmail'
563d8fb
jeff1evesque added a commit that referenced this issue Oct 16, 2017
@jeff1evesque
#3052: fix pytest indentation
1e93f1f
jeff1evesque added a commit that referenced this issue Oct 16, 2017
@jeff1evesque
#3052: register.jsx, dispatch in 'handleSubmit'
e8d5160
jeff1evesque added a commit that referenced this issue Oct 16, 2017
@jeff1evesque
#3052: register.jsx, move dispatch after 'if'
ade2c01
jeff1evesque added a commit that referenced this issue Oct 16, 2017
@jeff1evesque
#3052: email.py, replace '==' with 'is'
6cc5d43
jeff1evesque added a commit that referenced this issue Oct 16, 2017
@jeff1evesque
#3052: email.py, fix docstring typo
259d1b0
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: register.jsx, frontend validate fields
080b806
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: implement backend 'isValidEmail'
a7f4c92
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: fix pytest indentation
68fc9ef
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: register.jsx, dispatch in 'handleSubmit'
fab1dd9
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: register.jsx, move dispatch after 'if'
aa91fac
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: email.py, replace '==' with 'is'
05b3f63
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: register.jsx, remove spinner on error
f15bc47
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: register.jsx, invalid value stops spinner
c9e2a48
jeff1evesque added a commit that referenced this issue Oct 21, 2017
@jeff1evesque
#3052: email.py, fix docstring typo
4cc1574
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug frontend unit test
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
1 participant
@jeff1evesque