-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support new metric argument for nn2() #6
Conversation
Conflicts: R/nn.R man/RANN-defunct.Rd
Now,
|
The use of the environment is a nice way to speed things up. My only comment now would be: should we just bypass worker_nn2 for Euclidean distance? That way the implementation is essentially unchanged for the standard Euclidean distance. Either that or prefill the environment in onLoad |
For a long-term solution, I think it's best if the |
So the conclusion for the time being is that we simply refer to your new RANN1 package in the docs as implemented in your #10. This PR has therefore been superseded so I am closing it (even though some of the approaches you tried here were interesting). |
Fine with me, thanks. |
RANN1
Fixes #3.
Closes #4 (=contains it).