Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address deprecation warning in 3.7: collections -> collections.abc #39

Closed
walnutgeek opened this issue Jun 14, 2019 · 3 comments
Closed

Address deprecation warning in 3.7: collections -> collections.abc #39

walnutgeek opened this issue Jun 14, 2019 · 3 comments

Comments

@walnutgeek
Copy link
Contributor

walnutgeek commented Jun 14, 2019 •
edited
Loading

.../envs/hk37/lib/python3.7/site-packages/sniffer/api.py:27
.../envs/hk37/lib/python3.7/site-packages/sniffer/api.py:27: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
if not isinstance(func, collections.Callable):
walnutgeek added a commit to walnutgeek/sniffer that referenced this issue Jun 14, 2019
@walnutgeek
Address jeffh#39
5b462f6
@walnutgeek
Copy link
Contributor Author

walnutgeek commented Jun 14, 2019 •
edited
Loading

added PR #40

jeffh added a commit that referenced this issue Jun 21, 2019
@jeffh
Merge pull request #40 from walnutgeek/master
a79a2e0 
Address #39
@jeffh
Copy link
Owner

jeffh commented Jun 21, 2019

Merged. This should available in the next release - sometime this weekend.

@jeffh jeffh closed this as completed Jun 21, 2019
@walnutgeek
Copy link
Contributor Author

Confirming fix. Python 3.7 does not give any warning anymore with sniffer-0.4.1. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeffh @walnutgeek