Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecureString values gets exposed in defaultValue after deployment #60

Closed
RodrigoGroener opened this issue Aug 15, 2019 · 2 comments
Closed

Comments

@RodrigoGroener
Copy link

RodrigoGroener commented Aug 15, 2019

Source Logic App Definition with parameter "CRM_HTTP_AzureAD_Secret":

"CRM_HTTP_AzureAD_Secret": { "type": "SecureString" }

Creates following ARM Template Parameter

"paramCRM_HTTP_AzureAD_Secret": { "type": "securestring", "defaultValue": "" }

That is used in the embedded Logic App definition:

"CRM_HTTP_AzureAD_Secret": { "type": "SecureString", "defaultValue": "[parameters('paramCRM_HTTP_AzureAD_Secret')]" }

What leads to that the secrect gets exposed in the "defaultValue" after the deployment:

"CRM_HTTP_AzureAD_Secret": { "defaultValue": "XXXXXX SECRECT VALUE XXXXXXXX", "type": "SecureString" }

So i think it would be nice to remove default value output for SecureString oder SecureObject parameters in the created template.
What do you mean?

@MLogdberg
Copy link
Collaborator

Hi,
do you mean after the deploy in Azure? Meaning inside the Logic App when deployed?
That is hard for this tool to achive and I would sugest getting the value from keyvault insteead (via the keyvault action)

@MLogdberg
Copy link
Collaborator

This is solved but forgott to close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants